Skip to content

Add support for Python3.12 - #1790

Closed
kunalsz wants to merge 1 commit into
aboutcode-org:mainfrom
kunalsz:update-python
Closed

Add support for Python3.12#1790
kunalsz wants to merge 1 commit into
aboutcode-org:mainfrom
kunalsz:update-python

Conversation

@kunalsz

@kunalsz kunalsz commented Mar 1, 2025

Copy link
Copy Markdown

In reference to the issue #1576

Changes made

  • Python3.12 has been added to the Dockerfile,Makefile and CI Workflow

Signed-off-by: kunalsz <kunalavengers@gmail.com>
@Rishi-source

Copy link
Copy Markdown

Hi @kunalsz ,I think Directly adding support for python 3.12 would not do the job coz some libraries or their version are not compatible in python 3.12 as mentioned by @Dedsec0098 in one of his issue related to failing tests #1782 which means that some tests would be failing in 3.12. so you have to take a look on all of such issues which could come when workflow file runs on each pull request otherwise currently your code is cancelling the job as you can see in the image below.
jobs for python 3.9,3.10.3.11 are also giving error

Run make dev envfile
-> Bootstrap the virtualenv with PYTHON_EXE=python3.12
make: python3.12: Command not found
make: *** [Makefile:51: virtualenv] Error [12](https://github.com/kunalsz/vulnerablecode/actions/runs/13607460788/job/38041005157#step:5:13)7

PYTHON_EXE should not be changed imo as I am working on python 3.13 still I use python3 while running any python command on cli.
Screenshot 2025-03-02 at 9 21 56 AM

@kunalsz kunalsz closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants